Fix: Players cannot eat food due to incorrect InteractionResultHolder comparison#2
Merged
Rico040 merged 1 commit intoRico040:masterfrom Apr 22, 2026
Merged
Conversation
Using != on InteractionResultHolder objects always returns true because each call to InteractionResultHolder.pass() creates a new instance. This caused the onUseItem event to always cancel item usage, preventing players from eating food even when authenticated. Changed to compare getResult() with InteractionResult.PASS instead.
Rico040
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
Players are unable to eat food because the
onUseItemevent always cancels item usage, regardless of authentication status.Root Cause
Using
!=to compareInteractionResultHolderobjects does not work becauseInteractionResultHolder.pass()creates a new instance every time it is called. This causes the comparison to always returntrue, resulting in the event being permanently cancelled.Fix
Changed the comparison to use
.getResult() != InteractionResult.PASSinstead of comparing the holder objects directly.Testing
allow-item-using: false)